168492376
/
qskinny
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

parameter name aligned with the QML property

This commit is contained in:
Uwe Rathmann 2021-02-03 13:20:23 +01:00
parent e57c861b04
commit f0dd624306
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/controls/QskQuickItem.cpp
View File

@ -364,10 +364,19 @@ bool QskQuickItem::polishOnResize() const
bool QskQuickItem::layoutMirroring() const bool QskQuickItem::layoutMirroring() const
{ {
#if 1
/*
What about using Qt::LayoutDirection instead. It sounds
like a more expressive API and we do not run into conflicts
with the layoutMirroring() attached property for QML.
But what is the situation with locales, where the default direction
is RightToLeft ?
*/
return d_func()->effectiveLayoutMirror; return d_func()->effectiveLayoutMirror;
#endif
} }
void QskQuickItem::setLayoutMirroring( bool on, bool recursive ) void QskQuickItem::setLayoutMirroring( bool on, bool childrenInherit )
{ {
// Again we have to deal with an existing API made for QML, // Again we have to deal with an existing API made for QML,
// that is weired for C++: LayoutMirroring/QQuickLayoutMirroringAttached // that is weired for C++: LayoutMirroring/QQuickLayoutMirroringAttached
@ -379,9 +388,9 @@ void QskQuickItem::setLayoutMirroring( bool on, bool recursive )
Q_D( QQuickItem ); Q_D( QQuickItem );
if ( recursive != d->inheritMirrorFromItem ) if ( childrenInherit != d->inheritMirrorFromItem )
{ {
d->inheritMirrorFromItem = recursive; d->inheritMirrorFromItem = childrenInherit;
d->resolveLayoutMirror(); d->resolveLayoutMirror();
} }
@ -390,7 +399,7 @@ void QskQuickItem::setLayoutMirroring( bool on, bool recursive )
if ( on != d->effectiveLayoutMirror ) if ( on != d->effectiveLayoutMirror )
{ {
d->setLayoutMirror( on ); d->setLayoutMirror( on );
if ( recursive ) if ( childrenInherit )
d->resolveLayoutMirror(); d->resolveLayoutMirror();
} }
} }

2
src/controls/QskQuickItem.h
View File

@ -78,7 +78,7 @@ class QSK_EXPORT QskQuickItem : public QQuickItem
void setTabFence( bool ); void setTabFence( bool );
bool isTabFence() const; bool isTabFence() const;
void setLayoutMirroring( bool on, bool recursive = false ); void setLayoutMirroring( bool on, bool childrenInherit = false );
void resetLayoutMirroring(); void resetLayoutMirroring();
bool layoutMirroring() const; bool layoutMirroring() const;