diff --git a/CMakeLists.txt b/CMakeLists.txt index 1e058758..820b15c1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -3,7 +3,7 @@ # This file may be used under the terms of the QSkinny License, Version 1.0 ############################################################################ -cmake_minimum_required(VERSION 3.16.3) # unclear - TODO +cmake_minimum_required(VERSION 3.16.3) macro(qsk_setup_options) diff --git a/cmake/QskConfigMacros.cmake b/cmake/QskConfigMacros.cmake index 21beee6f..9cc72d5a 100644 --- a/cmake/QskConfigMacros.cmake +++ b/cmake/QskConfigMacros.cmake @@ -34,6 +34,9 @@ macro(qsk_enable_pedantic_flags) add_compile_definitions(QT_STRICT_ITERATORS) endif() + # note: setting CMAKE_CXX_COMPILER without CMAKE_CXX_COMPILER_ID + # will fail here + if ( ( CMAKE_CXX_COMPILER_ID MATCHES "GNU" ) OR ( CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) ) @@ -113,6 +116,8 @@ macro(qsk_initialize_build_flags) if ( NOT MSVC ) add_compile_options( -Wall -Wextra ) + else + add_compile_options(/W4 /WX) endif() endmacro()