From b7380d7543a3122460fb0300bf4c6dc237f9776a Mon Sep 17 00:00:00 2001 From: Rick Vogel Date: Wed, 28 Feb 2024 19:13:45 +0100 Subject: [PATCH 1/3] #399 add big object compiler flag for g++ even harder --- qmlexport/CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qmlexport/CMakeLists.txt b/qmlexport/CMakeLists.txt index a4660b24..b3d88227 100644 --- a/qmlexport/CMakeLists.txt +++ b/qmlexport/CMakeLists.txt @@ -65,3 +65,8 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") DESTINATION ${QSK_INSTALL_LIBS} OPTIONAL) endif() + +if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") + #target_compile_options(${target} PRIVATE "-Wa,-mbig-obj") + set_source_files_properties(QskQml.cpp PROPERTIES COMPILE_FLAGS "-Wa,-mbig-obj") +endif() From d43285809ad29982ca9bf0b2fa8ca8c9d1a56b61 Mon Sep 17 00:00:00 2001 From: Rick Vogel Date: Wed, 28 Feb 2024 19:29:21 +0100 Subject: [PATCH 2/3] print cmake variables --- qmlexport/CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qmlexport/CMakeLists.txt b/qmlexport/CMakeLists.txt index b3d88227..a6edc8b1 100644 --- a/qmlexport/CMakeLists.txt +++ b/qmlexport/CMakeLists.txt @@ -66,7 +66,11 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") ${QSK_INSTALL_LIBS} OPTIONAL) endif() -if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") +get_filename_component(compiler ${CMAKE_CXX_COMPILER} NAME_WE) +if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_SYSTEM_NAME STREQUAL "Windows" AND compiler STREQUAL "g++") + message(STATUS "CMAKE_CXX_COMPILER_ID: ${CMAKE_CXX_COMPILER_ID}") + message(STATUS "CMAKE_SYSTEM_NAME: ${CMAKE_SYSTEM_NAME}") + message(STATUS "compiler: ${compiler}") #target_compile_options(${target} PRIVATE "-Wa,-mbig-obj") set_source_files_properties(QskQml.cpp PROPERTIES COMPILE_FLAGS "-Wa,-mbig-obj") endif() From 3f75cc98c4b4428ddbee5450ec8b9400d572aa0c Mon Sep 17 00:00:00 2001 From: Rick Vogel Date: Wed, 28 Feb 2024 20:39:30 +0100 Subject: [PATCH 3/3] remove debug messages --- qmlexport/CMakeLists.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qmlexport/CMakeLists.txt b/qmlexport/CMakeLists.txt index a6edc8b1..6fd0e630 100644 --- a/qmlexport/CMakeLists.txt +++ b/qmlexport/CMakeLists.txt @@ -68,9 +68,5 @@ endif() get_filename_component(compiler ${CMAKE_CXX_COMPILER} NAME_WE) if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_SYSTEM_NAME STREQUAL "Windows" AND compiler STREQUAL "g++") - message(STATUS "CMAKE_CXX_COMPILER_ID: ${CMAKE_CXX_COMPILER_ID}") - message(STATUS "CMAKE_SYSTEM_NAME: ${CMAKE_SYSTEM_NAME}") - message(STATUS "compiler: ${compiler}") - #target_compile_options(${target} PRIVATE "-Wa,-mbig-obj") set_source_files_properties(QskQml.cpp PROPERTIES COMPILE_FLAGS "-Wa,-mbig-obj") endif()