compiler warnings fixed

examples/gallery/dialog/DialogPage.cpp

@@ -30,7 +30,7 @@ namespace
 
             TypeCount
         };
-        Q_ENUM( ButtonType );
+        Q_ENUM( ButtonType )
 
         Button( ButtonType type, QQuickItem* parent = nullptr )
             : QskPushButton( parent )

examples/iotdashboard/CircularProgressBar.h

@@ -28,7 +28,7 @@ class CircularProgressBar : public QskBoundedControl
 
     CircularProgressBar( qreal min, qreal max, QQuickItem* parent = nullptr );
     CircularProgressBar( QQuickItem* parent = nullptr );
-    ~CircularProgressBar();
+    ~CircularProgressBar() override;
 
     bool isIndeterminate() const;
     void setIndeterminate( bool on = true );

examples/iotdashboard/nodes/DiagramSegmentsNode.cpp

@@ -19,7 +19,7 @@ DiagramSegmentsNode::DiagramSegmentsNode()
 void DiagramSegmentsNode::update( const QRectF& rect, const QColor& color,
     const QVector< QVector< QPointF > >& dataPoints, int xGridLines )
 {
-    Q_UNUSED( rect );
+    Q_UNUSED( rect )
 
     if( color != m_color )
     {

examples/tabview/main.cpp

@@ -72,7 +72,6 @@ class TabView : public QskTabView
     {
         for ( int i = 0; i < 10; i++ )
         {
-            QString text;
             if ( i == 4 )
             {
                 const auto text = QStringLiteral( "Another Tab" );

inputcontext/QskInputContextPlugin.cpp

@@ -24,7 +24,7 @@ class QskPlatformInputContext final : public QPlatformInputContext
 
   public:
     QskPlatformInputContext();
-    virtual ~QskPlatformInputContext() = default;
+    ~QskPlatformInputContext() override = default;
 
     bool isValid() const override;
     bool hasCapability( Capability ) const override;

playground/invoker/main.cpp

@@ -10,35 +10,12 @@
 #include <QThread>
 #include <QTimer>
 
-void debugNone1()
+static void debugNone1() { qDebug() << "None 1"; }
-{
+static void debugNone2() { qDebug() << "None 2"; }
-    qDebug() << "None 1";
+static void debugValueI1( int i ) { qDebug() << "I1" << i; }
-}
+static void debugValueI2( int i ) { qDebug() << "I2" << i; }
-
+static void debugValueD( qreal d ) { qDebug() << "D" << d; }
-void debugNone2()
+static void debugValue( qreal d, int i ) { qDebug() << d << i; }
-{
-    qDebug() << "None 2";
-}
-
-void debugValueI1( int i )
-{
-    qDebug() << "I1" << i;
-}
-
-void debugValueI2( int i )
-{
-    qDebug() << "I2" << i;
-}
-
-void debugValueD( qreal d )
-{
-    qDebug() << "D" << d;
-}
-
-void debugValue( qreal d, int i )
-{
-    qDebug() << d << i;
-}
 
 class MyObject : public QObject
 {
@@ -166,7 +143,7 @@ class Application : public QCoreApplication
 #endif
     }
 
-    virtual ~Application()
+    ~Application() override
     {
         delete m_object;
     }

playground/shapes/GeometricShape.h

@@ -29,7 +29,7 @@ class GeometricShape : public ShapeItem
         Hexagon,
         Arc
     };
-    Q_ENUM( Figure );
+    Q_ENUM( Figure )
 
     GeometricShape( QQuickItem* parent = nullptr );
     GeometricShape( Figure figure, QQuickItem* parent = nullptr );

qmlexport/QskQml.hpp

@@ -202,7 +202,7 @@ namespace QskQml
         return qmlregister( TypeRegistration, &type );
     }
 
-    int registerUncreatableMetaObject(
+    inline int registerUncreatableMetaObject(
         const QMetaObject& staticMetaObject, const char* qmlName )
     {
         using namespace QQmlPrivate;

skins/material3/QskMaterial3Skin.cpp

@@ -115,12 +115,6 @@ namespace
             return QskGraphicIO::read( path );
         }
 
-        void setStandardSymbol( QskAspect aspect,
-            QskStandardSymbol::Type symbolType )
-        {
-            setSymbol( aspect, QskStandardSymbol::graphic( symbolType ) );
-        }
-
         const QskMaterial3Theme& m_pal;
     };
 
@@ -131,9 +125,7 @@ namespace
         font.setPixelSize( lineHeight );
 
         if( !qskFuzzyCompare( tracking, 0.0 ) )
-        {
             font.setLetterSpacing( QFont::AbsoluteSpacing, tracking );
-        }
 
         font.setWeight( weight );
 

src/common/QskBoxShapeMetrics.h

@@ -59,7 +59,7 @@ class QSK_EXPORT QskBoxShapeMetrics
 
         Proportional
     };
-    Q_ENUM( ScalingMode );
+    Q_ENUM( ScalingMode )
 
     constexpr QskBoxShapeMetrics() noexcept;
 

src/common/QskHctColor.cpp

@@ -544,7 +544,7 @@ static XYZ nthVertex( double y, int n )
     return { -1.0, -1.0, -1.0 };
 }
 
-void bisectToSegment( double y, double targetHue, XYZ& left, XYZ& right )
+static void bisectToSegment( double y, double targetHue, XYZ& left, XYZ& right )
 {
     left = { -1.0, -1.0, -1.0 };
     right = left;

src/common/QskMetaFunction.cpp

@@ -154,7 +154,7 @@ int QskMetaFunction::returnType() const
 
 size_t QskMetaFunction::parameterCount() const
 {
-    int count = 0;
+    size_t count = 0;
 
     if ( auto types = parameterTypes() )
     {

src/common/QskMetaFunction.hpp

@@ -35,9 +35,9 @@ class QskMetaFunction::FunctionCall : public QtPrivate::QSlotObjectBase
 
   protected:
     explicit inline FunctionCall( InvokeFunction f,
-            const int* m_parameterTypes = nullptr ):
+            const int* parameterTypes = nullptr ):
         QSlotObjectBase( f ),
-        m_parameterTypes( m_parameterTypes )
+        m_parameterTypes( parameterTypes )
     {
     }
 

src/common/QskMetaInvokable.h

@@ -132,8 +132,8 @@ QSK_EXPORT void qskInvokeMetaPropertyWrite(
     void* args[], Qt::ConnectionType = Qt::AutoConnection );
 
 QSK_EXPORT void qskInvokeMetaPropertyWrite(
-    const QObject* object, const QMetaProperty&,
+    QObject*, const QMetaProperty&, void* args[],
-    void* args[], Qt::ConnectionType = Qt::AutoConnection );
+    Qt::ConnectionType = Qt::AutoConnection );
 
 QSK_EXPORT QMetaMethod qskNotifySignal( const QMetaObject*, const char* propertyName );
 QSK_EXPORT QMetaMethod qskNotifySignal( const QObject*, const char* propertyName );

src/controls/QskMenuSkinlet.h

@@ -25,7 +25,7 @@ class QSK_EXPORT QskMenuSkinlet : public QskPopupSkinlet
     };
 
     Q_INVOKABLE QskMenuSkinlet( QskSkin* = nullptr );
-    ~QskMenuSkinlet();
+    ~QskMenuSkinlet() override;
 
     QRectF subControlRect( const QskSkinnable*,
         const QRectF&, QskAspect::Subcontrol ) const override;

src/controls/QskPopupSkinlet.cpp

@@ -16,7 +16,7 @@ namespace
     class RootNode : public QSGNode
     {
       public:
-        ~RootNode()
+        ~RootNode() override
         {
             delete m_clipNode;
             delete m_transformNode;

src/controls/QskProgressBarSkinlet.cpp

@@ -85,7 +85,6 @@ QRectF QskProgressBarSkinlet::subControlRect(
 
     if( subControl == QskProgressBar::Bar )
     {
-        const auto bar = static_cast< const QskProgressBar* >( skinnable );
         return barRect( bar );
     }
 

src/controls/QskRadioBox.cpp

@@ -177,16 +177,13 @@ void QskRadioBox::keyPressEvent( QKeyEvent* event )
     }
     else
     {
-        setFocusedIndex( ( float ) nextTabIndex );
+        setFocusedIndex( nextTabIndex );
 
         const auto aspect = Ripple | QskAspect::Metric | QskAspect::Position;
         const auto hint = animationHint( aspect | skinStates() );
 
         if( hint.isValid() )
-        {
+            startTransition( aspect, hint, currentTabIndex, nextTabIndex );
-            startTransition( aspect, hint,
-                ( float ) currentTabIndex, ( float ) nextTabIndex );
-        }
     }
 
     update();

src/controls/QskRadioBoxSkinlet.cpp

@@ -83,7 +83,7 @@ QSGNode* QskRadioBoxSkinlet::updateSubNode( const QskSkinnable* skinnable,
 
         case RippleRole:
             return updateBoxNode( skinnable, node, Q::Ripple );
-    };
+    }
 
     return Inherited::updateSubNode( skinnable, nodeRole, node );
 }

src/controls/QskScrollArea.cpp

@@ -201,7 +201,7 @@ namespace
 
       public:
         ClipItem( QskScrollArea* );
-        virtual ~ClipItem();
+        ~ClipItem() override;
 
         void enableGeometryListener( bool on );
 

src/controls/QskSkinManager.cpp

@@ -203,23 +203,6 @@ namespace
             return m_skinMap.keys();
         }
 
-        QStringList skinNames( const QString& factoryId ) const
-        {
-            const auto it = m_factoryMap.constFind( factoryId );
-            if ( it != m_factoryMap.constEnd() )
-            {
-                const auto& data = it.value();
-
-                if ( data.factory )
-                    return data.factory->skinNames();
-
-                if ( data.loader )
-                    return data.loader->skinNames();
-            }
-
-            return QStringList();
-        }
-
         void insertFactory( FactoryLoader* loader )
         {
             auto& data = m_factoryMap[ loader->factoryId() ];

src/controls/QskSkinTransition.cpp

@@ -160,7 +160,7 @@ namespace
         Q_OBJECT
 
       public:
-        ~ApplicationAnimator();
+        ~ApplicationAnimator() override;
 
         WindowAnimator* windowAnimator( const QQuickWindow* );
 

src/controls/QskTabBar.cpp

@@ -184,7 +184,7 @@ namespace
             auto boxSize = viewContentsRect().size();
             boxSize = qskConstrainedItemSize( box, boxSize );
 
-            if ( auto box = buttonBox() )
+            if ( box )
                 box->setSize( boxSize );
 
             enableAutoTranslation( false );

src/graphic/QskGraphicIO.cpp

@@ -138,7 +138,7 @@ static inline void qskReadStateData(
     quint16 flags;
     s >> flags;
 
-    data.flags = ( QPaintEngine::DirtyFlags ) flags;
+    data.flags = static_cast< QPaintEngine::DirtyFlags >( flags );
 
     if ( data.flags & QPaintEngine::DirtyPen )
         s >> data.pen;
@@ -316,7 +316,7 @@ bool QskGraphicIO::write( const QskGraphic& graphic, QIODevice* dev )
     stream.setByteOrder( QDataStream::BigEndian );
     stream.writeRawData( qskMagicNumber, 4 );
 
-    const int numCommands = graphic.commands().size();
+    const auto numCommands = graphic.commands().size();
     const QskPainterCommand* cmds = graphic.commands().constData();
 
     stream << static_cast< quint32 >( numCommands );

src/graphic/QskGraphicImageProvider.cpp

@@ -32,7 +32,7 @@ static inline QSize qskGraphicSize( const QskGraphic& graphic,
     if ( requestedSize.width() < 0 )
     {
         const auto f = requestedSize.height() / defaultSize.height();
-        return QSize( f * defaultSize.width(),
+        return QSize( static_cast< int >( f * defaultSize.width() ),
             static_cast< int >( requestedSize.height() ) );
     }
 

src/inputpanel/QskInputContext.cpp

@@ -554,7 +554,7 @@ QskTextPredictor* QskInputContextFactory::createPredictor( const QLocale& locale
 #if HUNSPELL
     return new QskHunspellTextPredictor( locale );
 #else
-    Q_UNUSED( locale );
+    Q_UNUSED( locale )
 #endif
 
     return nullptr;

src/inputpanel/QskInputContext.h

@@ -48,7 +48,7 @@ class QSK_EXPORT QskInputContext : public QObject
 
   public:
     QskInputContext();
-    virtual ~QskInputContext();
+    ~QskInputContext() override;
 
     void setFactory( QskInputContextFactory* );
     QskInputContextFactory* factory() const;

src/inputpanel/QskInputPanel.cpp

@@ -148,16 +148,14 @@ namespace
                         // Let the input field update right away, otherwise
                         // we'll get weird effects with fast backspace presses:
                         Q_EMIT keyProcessingFinished( m_currentResult );
-                        return;
                     }
                     else
                     {
                         m_currentResult.key = Qt::Key_Backspace;
                         Q_EMIT keyProcessingFinished( m_currentResult );
-                        return;
                     }
 
-                    break;
+                    return;
                 }
                 case Qt::Key_Return:
                 {

src/layouts/QskGridBox.cpp

@@ -518,10 +518,10 @@ void QskGridBox::dump() const
 
         if ( auto item = engine.itemAt( i ) )
         {
-            const auto constraint = qskSizeConstraint( item, Qt::PreferredSize );
+            const auto size = qskSizeConstraint( item, Qt::PreferredSize );
 
             debug << item->metaObject()->className()
-                  << " w:" << constraint.width() << " h:" << constraint.height();
+                  << " w:" << size.width() << " h:" << size.height();
         }
         else
         {

src/layouts/QskLayoutChain.cpp

@@ -250,7 +250,7 @@ QskLayoutChain::Segments QskLayoutChain::segments( qreal size ) const
         const qreal padding = size - m_boundingMetrics.maximum();
 
         qreal offset = 0.0;
-        qreal extra = 0.0;;
+        qreal extra = 0.0;
 
         switch( m_fillMode )
         {
@@ -424,13 +424,13 @@ QskLayoutChain::Segments QskLayoutChain::preferredStretched( qreal size ) const
             if ( factors[i] < 0.0 )
                 continue;
 
-            const auto size = sumSizes * factors[i] / sumFactors;
+            const auto sz = sumSizes * factors[i] / sumFactors;
 
             const auto& hint = m_cells[i].metrics;
             const auto boundedSize =
-                qBound( hint.preferred(), size, hint.maximum() );
+                qBound( hint.preferred(), sz, hint.maximum() );
 
-            if ( boundedSize != size )
+            if ( boundedSize != sz )
             {
                 segments[i].length = boundedSize;
                 sumSizes -= boundedSize;

src/layouts/QskLinearBox.cpp

@@ -556,9 +556,9 @@ void QskLinearBox::dump() const
 
         if ( auto item = engine.itemAt( i ) )
         {
-            const auto constraint = qskSizeConstraint( item, Qt::PreferredSize );
+            const auto size = qskSizeConstraint( item, Qt::PreferredSize );
             debug << item->metaObject()->className()
-                  << " w:" << constraint.width() << " h:" << constraint.height();
+                  << " w:" << size.width() << " h:" << size.height();
         }
         else
         {

src/layouts/QskStackBox.cpp

@@ -450,9 +450,9 @@ void QskStackBox::dump() const
 
         debug << "  " << i << ": ";
 
-        const auto constraint = qskSizeConstraint( item, Qt::PreferredSize );
+        const auto size = qskSizeConstraint( item, Qt::PreferredSize );
         debug << item->metaObject()->className()
-              << " w:" << constraint.width() << " h:" << constraint.height();
+              << " w:" << size.width() << " h:" << size.height();
 
         if ( i == m_data->currentIndex )
             debug << " [X]";

src/nodes/QskArcNode.cpp

@@ -50,6 +50,4 @@ QskHashValue QskArcNode::hash( const void* nodeData ) const
 
     auto h = arcData->metrics.hash();
     return arcData->gradient.hash( h );
-
-    return h;
 }

src/nodes/QskBoxBasicStroker.cpp

@@ -31,7 +31,7 @@ namespace
     }
 
     inline int edgeToIndex( Qt::Edge edge )
-        { return qCountTrailingZeroBits( (quint8) edge ); }
+        { return qCountTrailingZeroBits( static_cast< quint8 >( edge ) ); }
 
     class CornerIterator : public QskVertex::ArcIterator
     {

src/nodes/QskBoxGradientStroker.cpp

@@ -183,7 +183,7 @@ namespace
     {
       public:
         Point() = default;
-        inline Point( qreal x, qreal y, qreal v ): x( x ), y( y ), v( v ) {};
+        inline Point( qreal x, qreal y, qreal v ): x( x ), y( y ), v( v ) {}
 
         qreal x = 0;
         qreal y = 0;

src/nodes/QskBoxNode.cpp

@@ -26,7 +26,7 @@ namespace
     };
 }
 
-void qskUpdateChildren( QSGNode* parentNode, quint8 role, QSGNode* node )
+static void qskUpdateChildren( QSGNode* parentNode, quint8 role, QSGNode* node )
 {
     static const QVector< quint8 > roles = { ShadowRole, BoxRole, FillRole };
 

src/nodes/QskColorRamp.cpp

@@ -35,7 +35,7 @@ namespace
             setVerticalWrapMode( wrapMode );
 
             setFiltering( QSGTexture::Linear );
-        };
+        }
 
       private:
         static inline QSGTexture::WrapMode wrapMode( QskGradient::SpreadMode spreadMode )

src/nodes/QskRichTextRenderer.cpp

@@ -83,15 +83,15 @@ namespace
 
         inline void setAlignment( Qt::Alignment alignment )
         {
-            setHAlign( ( QQuickText::HAlignment )( int( alignment ) & 0x0f ) );
+            setHAlign( static_cast< QQuickText::HAlignment >( int( alignment ) & 0x0f ) );
-            setVAlign( ( QQuickText::VAlignment )( int( alignment ) & 0xf0 ) );
+            setVAlign( static_cast< QQuickText::VAlignment >( int( alignment ) & 0xf0 ) );
         }
 
         inline void setOptions( const QskTextOptions& options )
         {
             // what about Qt::TextShowMnemonic ???
-            setTextFormat( ( QQuickText::TextFormat ) options.format() );
+            setTextFormat( static_cast< QQuickText::TextFormat >( options.format() ) );
-            setElideMode( ( QQuickText::TextElideMode ) options.elideMode() );
+            setElideMode( static_cast< QQuickText::TextElideMode >( options.elideMode() ) );
             setMaximumLineCount( options.maximumLineCount() );
             setWrapMode( static_cast< QQuickText::WrapMode >( options.wrapMode() ) );
         }

src/nodes/QskScaleRenderer.h

@@ -28,7 +28,7 @@ class QSK_EXPORT QskScaleRenderer
 {
   public:
     QskScaleRenderer();
-    ~QskScaleRenderer();
+    virtual ~QskScaleRenderer();
 
     void setOrientation( Qt::Orientation );
     void setAlignment( Qt::Alignment );

src/nodes/QskVertex.h

@@ -73,7 +73,7 @@ namespace QskVertex
     {
     }
 
-    inline Color Color::interpolatedTo( Color colorTo, double ratio ) const noexcept
+    inline Color Color::interpolatedTo( Color colorTo, qreal ratio ) const noexcept
     {
         if ( ratio <= 0.0 )
             return *this;
@@ -81,11 +81,15 @@ namespace QskVertex
         if ( ratio >= 1.0 )
             return colorTo;
 
-        const double t = ratio;
+        const auto t = ratio;
-        const double rt = 1.0 - ratio;
+        const auto rt = 1.0 - ratio;
 
-        return Color( rt * r + t * colorTo.r, rt * g + t * colorTo.g,
+        return Color(
-            rt * b + t * colorTo.b, rt * a + t * colorTo.a );
+            static_cast< unsigned char >( rt * r + t * colorTo.r ),
+            static_cast< unsigned char >( rt * g + t * colorTo.g ),
+            static_cast< unsigned char >( rt * b + t * colorTo.b ),
+            static_cast< unsigned char >( rt * a + t * colorTo.a ) 
+        );
     }
 
     inline constexpr bool Color::operator==( const Color& other ) const noexcept