From 278fca26d7b4fd2dc810d610c6a2f6dccb68b1ec Mon Sep 17 00:00:00 2001 From: Uwe Rathmann Date: Mon, 17 Jun 2024 11:51:36 +0200 Subject: [PATCH 1/4] CI: Fix builds on Mac --- .github/workflows/cmake.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 7d021744..30ec807c 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -277,7 +277,8 @@ jobs: - name: Install dependencies on macos if: startsWith(matrix.config.os, 'macos') run: | - brew install p7zip cmake ninja + find /opt/homebrew/ -name EXTERNALLY-MANAGED|xargs rm + brew install cmake ninja ninja --version cmake --version @@ -322,7 +323,7 @@ jobs: - name: Install Qt5 if: endsWith(matrix.config.name, 'Qt5') - uses: jurplel/install-qt-action@v3 + uses: jurplel/install-qt-action@v4 with: version: "5.15.2" target: "desktop" @@ -336,7 +337,7 @@ jobs: - name: Install Qt6 if: endsWith(matrix.config.name, 'Qt6') - uses: jurplel/install-qt-action@v3 + uses: jurplel/install-qt-action@v4 with: version: "6.5.0" target: "desktop" From b99ed6ec9bdc76ee8eb7244a6a03a5e6b1eaa05a Mon Sep 17 00:00:00 2001 From: Uwe Rathmann Date: Mon, 17 Jun 2024 12:07:29 +0200 Subject: [PATCH 2/4] compiler warnings ( unused definitions ) fixed --- src/common/QskGraduation.cpp | 2 -- src/common/QskMetaInvokable.cpp | 9 --------- 2 files changed, 11 deletions(-) diff --git a/src/common/QskGraduation.cpp b/src/common/QskGraduation.cpp index 3d20132d..1eab1f28 100644 --- a/src/common/QskGraduation.cpp +++ b/src/common/QskGraduation.cpp @@ -17,8 +17,6 @@ namespace Engine { // What about using qskFuzzyCompare and friends ??? - const double _eps = 1.0e-6; - inline int fuzzyCompare( double value1, double value2, double intervalSize ) { const double eps = std::abs( 1.0e-6 * intervalSize ); diff --git a/src/common/QskMetaInvokable.cpp b/src/common/QskMetaInvokable.cpp index 09a576f0..31a6c0df 100644 --- a/src/common/QskMetaInvokable.cpp +++ b/src/common/QskMetaInvokable.cpp @@ -26,15 +26,6 @@ static void qskRegisterMetaInvokable() Q_CONSTRUCTOR_FUNCTION( qskRegisterMetaInvokable ) -static inline void* qskMetaTypeCreate( int type, const void* copy ) -{ -#if QT_VERSION >= QT_VERSION_CHECK( 6, 0, 0 ) - return QMetaType( type ).create( copy ); -#else - return QMetaType::create( type, copy ); -#endif -} - namespace { using CallFunction = QObjectPrivate::StaticMetaCallFunction; From a8c1bb5c77db161de9628df24fd7ffdf2da48965 Mon Sep 17 00:00:00 2001 From: Uwe Rathmann Date: Mon, 17 Jun 2024 12:21:06 +0200 Subject: [PATCH 3/4] Qt5/Mac CI fixed --- .github/workflows/cmake.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml index 30ec807c..126abdde 100644 --- a/.github/workflows/cmake.yml +++ b/.github/workflows/cmake.yml @@ -175,7 +175,7 @@ jobs: } - { name: "macOS Latest Clang Qt5", - os: macos-latest, + os: macos-13, artifact: "macos_clang.7z", build_type: "Release", cc: "clang", From 1aaf4ec296aeb2e42064c6b05911bded0b219742 Mon Sep 17 00:00:00 2001 From: Uwe Rathmann Date: Tue, 25 Jun 2024 08:51:43 +0200 Subject: [PATCH 4/4] Qt 6.8 warnings fixed --- src/graphic/QskGraphic.cpp | 10 ++++++++++ src/graphic/QskGraphic.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/graphic/QskGraphic.cpp b/src/graphic/QskGraphic.cpp index 29127cf7..aed3f610 100644 --- a/src/graphic/QskGraphic.cpp +++ b/src/graphic/QskGraphic.cpp @@ -496,6 +496,16 @@ int QskGraphic::metric( PaintDeviceMetric deviceMetric ) const value = metric( PdmDevicePixelRatio ) * devicePixelRatioFScale(); break; } +#if QT_VERSION >= QT_VERSION_CHECK( 6, 8, 0 ) + case PdmDevicePixelRatioF_EncodedA: + case PdmDevicePixelRatioF_EncodedB: + { +#if 0 + value = QPaintDevice::encodeMetricF( metric, devicePixelRatio() ); +#endif + break; + } +#endif } return value; diff --git a/src/graphic/QskGraphic.h b/src/graphic/QskGraphic.h index d9e8c5a0..34565aa0 100644 --- a/src/graphic/QskGraphic.h +++ b/src/graphic/QskGraphic.h @@ -35,6 +35,8 @@ class QSK_EXPORT QskGraphic : public QPaintDevice Q_PROPERTY( QSizeF defaultSize READ defaultSize ) Q_PROPERTY( quint64 modificationId READ modificationId ) + using Inherited = QPaintDevice; + public: enum RenderHint {