using references

This commit is contained in:
Uwe Rathmann 2022-02-04 16:18:14 +01:00
parent ac8ef9cd5a
commit 18b7f9590e
4 changed files with 14 additions and 10 deletions

View File

@ -207,11 +207,8 @@ QDebug operator<<( QDebug debug, const QskBoxBorderColors& colors )
debug << "BoxBorderColors" << '('; debug << "BoxBorderColors" << '(';
debug << " L" << colors.gradient( Qsk::Left ); debug << " L" << colors.gradient( Qsk::Left );
debug << ", T" << colors.gradient( Qsk::Top ); debug << ", T" << colors.gradient( Qsk::Top );
debug << ", R" << colors.gradient( Qsk::Right ); debug << ", R" << colors.gradient( Qsk::Right );
debug << ", B" << colors.gradient( Qsk::Bottom ); debug << ", B" << colors.gradient( Qsk::Bottom );
debug << " )"; debug << " )";

View File

@ -39,7 +39,7 @@ class QSK_EXPORT QskBoxBorderColors
const QskGradient& right, const QskGradient& bottom ); const QskGradient& right, const QskGradient& bottom );
void setGradient( Qsk::Position, const QskGradient& ); void setGradient( Qsk::Position, const QskGradient& );
QskGradient gradient( Qsk::Position ) const; const QskGradient& gradient( Qsk::Position ) const;
void setGradientAt( Qt::Edges, const QskGradient& ); void setGradientAt( Qt::Edges, const QskGradient& );
const QskGradient& gradientAt( Qt::Edge ) const; const QskGradient& gradientAt( Qt::Edge ) const;
@ -73,7 +73,7 @@ inline bool QskBoxBorderColors::operator!=( const QskBoxBorderColors& other ) co
return !( *this == other ); return !( *this == other );
} }
inline QskGradient QskBoxBorderColors::gradient( Qsk::Position position ) const inline const QskGradient& QskBoxBorderColors::gradient( Qsk::Position position ) const
{ {
return m_gradients[ position ]; return m_gradients[ position ];
} }

View File

@ -541,7 +541,7 @@ namespace
return m_color1.interpolatedTo( m_color2, step / m_stepCount ); return m_color1.interpolatedTo( m_color2, step / m_stepCount );
} }
inline QskGradient gradient() const inline const QskGradient& gradient() const
{ {
return m_gradient; return m_gradient;
} }
@ -605,10 +605,13 @@ namespace
if ( borderLines ) if ( borderLines )
{ {
linesBR = borderLines; linesBR = borderLines;
linesTR = linesBR + numCornerLines linesTR = linesBR + numCornerLines
+ additionalGradientStops( borderMapBR.gradient() ); + additionalGradientStops( borderMapBR.gradient() );
linesTL = linesTR + numCornerLines linesTL = linesTR + numCornerLines
+ additionalGradientStops( borderMapTR.gradient() ); + additionalGradientStops( borderMapTR.gradient() );
linesBL = linesTL + numCornerLines linesBL = linesTL + numCornerLines
+ additionalGradientStops( borderMapTL.gradient() ); + additionalGradientStops( borderMapTL.gradient() );
} }
@ -624,10 +627,13 @@ namespace
if ( borderLines ) if ( borderLines )
{ {
linesTR = borderLines + 1; linesTR = borderLines + 1;
linesTL = linesTR + numCornerLines linesTL = linesTR + numCornerLines
+ additionalGradientStops( borderMapTR.gradient() ); + additionalGradientStops( borderMapTR.gradient() );
linesBL = linesTL + numCornerLines linesBL = linesTL + numCornerLines
+ additionalGradientStops( borderMapTL.gradient() ); + additionalGradientStops( borderMapTL.gradient() );
linesBR = linesBL + numCornerLines linesBR = linesBL + numCornerLines
+ additionalGradientStops( borderMapBL.gradient() ); + additionalGradientStops( borderMapBL.gradient() );
} }
@ -827,6 +833,7 @@ namespace
+ additionalGradientStops( borderMapTR.gradient() ) + additionalGradientStops( borderMapTR.gradient() )
+ additionalGradientStops( borderMapTL.gradient() ) + additionalGradientStops( borderMapTL.gradient() )
+ additionalGradientStops( borderMapBL.gradient() ); + additionalGradientStops( borderMapBL.gradient() );
const int k = 4 * numCornerLines + additionalStops; const int k = 4 * numCornerLines + additionalStops;
if ( orientation == Qt::Vertical ) if ( orientation == Qt::Vertical )

View File

@ -422,10 +422,10 @@ static inline void qskCreateBorder(
const QskBoxRenderer::Quad& out, const QskBoxRenderer::Quad& in, const QskBoxRenderer::Quad& out, const QskBoxRenderer::Quad& in,
const QskBoxBorderColors& colors, Line* line ) const QskBoxBorderColors& colors, Line* line )
{ {
const QskGradient gradientLeft = colors.gradient( Qsk::Left ); const auto& gradientLeft = colors.gradient( Qsk::Left );
const QskGradient gradientRight = colors.gradient( Qsk::Right ); const auto& gradientRight = colors.gradient( Qsk::Right );
const QskGradient gradientTop = colors.gradient( Qsk::Top ); const auto& gradientTop = colors.gradient( Qsk::Top );
const QskGradient gradientBottom = colors.gradient( Qsk::Bottom ); const auto& gradientBottom = colors.gradient( Qsk::Bottom );
// qdebug // qdebug