diff --git a/designsystems/fluent2/QskFluent2Icons.qrc b/designsystems/fluent2/QskFluent2Icons.qrc index 4e322fd8..7587fb4c 100644 --- a/designsystems/fluent2/QskFluent2Icons.qrc +++ b/designsystems/fluent2/QskFluent2Icons.qrc @@ -1,10 +1,7 @@ icons/qvg/checkmark.qvg - icons/qvg/combo-box-arrow-closed.qvg - icons/qvg/combo-box-arrow-open.qvg - icons/qvg/segmented-button-check.qvg - icons/qvg/spin-box-arrow-down.qvg - icons/qvg/spin-box-arrow-up.qvg + icons/qvg/chevron_down.qvg + icons/qvg/chevron_up.qvg diff --git a/designsystems/fluent2/QskFluent2Skin.cpp b/designsystems/fluent2/QskFluent2Skin.cpp index 993a3dcf..3ccb3bc2 100644 --- a/designsystems/fluent2/QskFluent2Skin.cpp +++ b/designsystems/fluent2/QskFluent2Skin.cpp @@ -419,7 +419,6 @@ void Editor::setupCheckBoxMetrics() setStrutSize( Q::Box, { 20_px, 20_px } ); // 18 + 2*1 border setBoxShape( Q::Box, 4_px ); // adapt to us taking the border into account setBoxBorderMetrics( Q::Box, 1_px ); - setPadding( Q::Box, 5_px ); // "icon size" setFontRole( Q::Text, Fluent2::Body ); } @@ -548,9 +547,9 @@ void Editor::setupComboBoxMetrics() setAlignment( Q::Text, Qt::AlignLeft | Qt::AlignVCenter ); setFontRole( Q::Text, Fluent2::Body ); - setStrutSize( Q::StatusIndicator, 12_px, 12_px ); - setSymbol( Q::StatusIndicator, symbol( "spin-box-arrow-down" ) ); - setSymbol( Q::StatusIndicator | Q::PopupOpen, symbol( "spin-box-arrow-up" ) ); + setStrutSize( Q::StatusIndicator, 16_px, 16_px ); + setSymbol( Q::StatusIndicator, symbol( "chevron_down" ) ); + // setSymbol( Q::StatusIndicator | Q::PopupOpen, symbol( "chevron_up" ) ); // Using Focused (Pressed doesn't exist yet): setBoxBorderMetrics( Q::Panel | Q::Focused, { 1_px, 1_px, 1_px, 2_px } ); @@ -1523,20 +1522,19 @@ void Editor::setupSpinBoxMetrics() setPadding( Q::TextPanel, { 11_px, 0, 11_px, 0 } ); -#if 1 - // probably obsolete once QskGraphic supports viewBox - setStrutSize( Q::UpPanel, 32_px, 20_px ); - setPadding( Q::UpPanel, { 11_px, 7_px, 11_px, 7_px } ); + for ( auto panel : { Q::UpPanel, Q::DownPanel } ) + setStrutSize( panel, 32_px, 18_px ); - setStrutSize( Q::DownPanel, 34_px, 20_px ); - setPadding( Q::DownPanel, { 11_px, 7_px, 13_px, 7_px } ); + setSymbol( Q::UpIndicator, symbol( "chevron_up" ) ); + setSymbol( Q::DownIndicator, symbol( "chevron_down" ) ); + + setPadding( Q::UpPanel, { 0, 1_px, 0, 0 } ); + setPadding( Q::DownPanel, { 0, 0, 0, 1_px } ); + +#if 0 + // QskSpinBox::Pressed is missing yet + setBoxBorderMetrics( Q::Panel | Q::Pressed, { 1_px, 1_px, 1_px, 2_px } ); #endif - - setSymbol( Q::UpIndicator, symbol( "spin-box-arrow-up" ) ); - setSymbol( Q::DownIndicator, symbol( "spin-box-arrow-down" ) ); - - // Focused (Pressed doesn't exist yet): - setBoxBorderMetrics( Q::Panel | Q::Focused, { 1_px, 1_px, 1_px, 2_px } ); } void Editor::setupSpinBoxColors( @@ -1599,8 +1597,17 @@ void Editor::setupSpinBoxColors( panelColor = rgbSolid( panelColor, pal.background.solid.base ); setGradient( panel, panelColor ); + setBoxBorderGradient( panel, borderColor1, borderColor2, panelColor ); + if ( state == Q::Focused ) + { + const auto colors = boxBorderColors( panel ); + + setBoxBorderColors( panel | Q::Decreasing, colors ); + setBoxBorderColors( panel | Q::Increasing, colors ); + } + setColor( text, textColor ); setGraphicRole( upIndicator, graphicRole ); diff --git a/designsystems/fluent2/icons/README b/designsystems/fluent2/icons/README new file mode 100644 index 00000000..a45cea97 --- /dev/null +++ b/designsystems/fluent2/icons/README @@ -0,0 +1,10 @@ +SVGs have been taken from https://github.com/microsoft/fluentui-system-icons/tree/main/assets. + +Icons are available in different sizes. As SVGs can be scaled we only need +one version of them - chosing the '12'. + +As we are replacing the colors of the SVGs using graphic filters we set the +color in the SVGs manually to black ( instead of #212121 ). So they are in +line with icons coming from somewhere else. + +Names have been shortened ( ic_fluent_xyz_16_regular.svg -> xyz.svg ) diff --git a/designsystems/fluent2/icons/checkmark.svg b/designsystems/fluent2/icons/checkmark.svg index 70b15e35..f87de9aa 100644 --- a/designsystems/fluent2/icons/checkmark.svg +++ b/designsystems/fluent2/icons/checkmark.svg @@ -1,4 +1,3 @@ - - + + - diff --git a/designsystems/fluent2/icons/chevron_down.svg b/designsystems/fluent2/icons/chevron_down.svg new file mode 100644 index 00000000..8ac9ed11 --- /dev/null +++ b/designsystems/fluent2/icons/chevron_down.svg @@ -0,0 +1,3 @@ + + + diff --git a/designsystems/fluent2/icons/chevron_up.svg b/designsystems/fluent2/icons/chevron_up.svg new file mode 100644 index 00000000..28426e1d --- /dev/null +++ b/designsystems/fluent2/icons/chevron_up.svg @@ -0,0 +1,3 @@ + + + diff --git a/designsystems/fluent2/icons/combo-box-arrow-closed.svg b/designsystems/fluent2/icons/combo-box-arrow-closed.svg deleted file mode 100644 index c288b426..00000000 --- a/designsystems/fluent2/icons/combo-box-arrow-closed.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/designsystems/fluent2/icons/combo-box-arrow-open.svg b/designsystems/fluent2/icons/combo-box-arrow-open.svg deleted file mode 100644 index 4138c2cd..00000000 --- a/designsystems/fluent2/icons/combo-box-arrow-open.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/designsystems/fluent2/icons/qvg/checkmark.qvg b/designsystems/fluent2/icons/qvg/checkmark.qvg index dea06251..40ab0c75 100644 Binary files a/designsystems/fluent2/icons/qvg/checkmark.qvg and b/designsystems/fluent2/icons/qvg/checkmark.qvg differ diff --git a/designsystems/fluent2/icons/qvg/chevron_down.qvg b/designsystems/fluent2/icons/qvg/chevron_down.qvg new file mode 100644 index 00000000..a8d90d49 Binary files /dev/null and b/designsystems/fluent2/icons/qvg/chevron_down.qvg differ diff --git a/designsystems/fluent2/icons/qvg/chevron_up.qvg b/designsystems/fluent2/icons/qvg/chevron_up.qvg new file mode 100644 index 00000000..11f3abc4 Binary files /dev/null and b/designsystems/fluent2/icons/qvg/chevron_up.qvg differ diff --git a/designsystems/fluent2/icons/qvg/combo-box-arrow-closed.qvg b/designsystems/fluent2/icons/qvg/combo-box-arrow-closed.qvg deleted file mode 100644 index 83f33a45..00000000 Binary files a/designsystems/fluent2/icons/qvg/combo-box-arrow-closed.qvg and /dev/null differ diff --git a/designsystems/fluent2/icons/qvg/combo-box-arrow-open.qvg b/designsystems/fluent2/icons/qvg/combo-box-arrow-open.qvg deleted file mode 100644 index 1e757789..00000000 Binary files a/designsystems/fluent2/icons/qvg/combo-box-arrow-open.qvg and /dev/null differ diff --git a/designsystems/fluent2/icons/qvg/segmented-button-check.qvg b/designsystems/fluent2/icons/qvg/segmented-button-check.qvg deleted file mode 100644 index 1b0148e3..00000000 Binary files a/designsystems/fluent2/icons/qvg/segmented-button-check.qvg and /dev/null differ diff --git a/designsystems/fluent2/icons/qvg/spin-box-arrow-down.qvg b/designsystems/fluent2/icons/qvg/spin-box-arrow-down.qvg deleted file mode 100644 index 376094d9..00000000 Binary files a/designsystems/fluent2/icons/qvg/spin-box-arrow-down.qvg and /dev/null differ diff --git a/designsystems/fluent2/icons/qvg/spin-box-arrow-up.qvg b/designsystems/fluent2/icons/qvg/spin-box-arrow-up.qvg deleted file mode 100644 index c45983f9..00000000 Binary files a/designsystems/fluent2/icons/qvg/spin-box-arrow-up.qvg and /dev/null differ diff --git a/designsystems/fluent2/icons/segmented-button-check.svg b/designsystems/fluent2/icons/segmented-button-check.svg deleted file mode 100644 index b0b66ac9..00000000 --- a/designsystems/fluent2/icons/segmented-button-check.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/designsystems/fluent2/icons/spin-box-arrow-down.svg b/designsystems/fluent2/icons/spin-box-arrow-down.svg deleted file mode 100644 index a3ffcd48..00000000 --- a/designsystems/fluent2/icons/spin-box-arrow-down.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - - diff --git a/designsystems/fluent2/icons/spin-box-arrow-up.svg b/designsystems/fluent2/icons/spin-box-arrow-up.svg deleted file mode 100644 index 34301711..00000000 --- a/designsystems/fluent2/icons/spin-box-arrow-up.svg +++ /dev/null @@ -1,4 +0,0 @@ - - - -