making clang happier

src/common/QskMetaInvokable.h

@@ -12,7 +12,7 @@
 #include <Qt>
 
 class QskMetaFunction;
-class QMetaObject;
+struct QMetaObject;
 class QMetaMethod;
 class QMetaProperty;
 class QObject;

src/controls/QskFocusIndicator.cpp

@@ -29,7 +29,7 @@ class QskFocusIndicator::PrivateData
 public:
     void resetConnections()
     {
-        for ( const auto connection : connections )
+        for ( const auto& connection : connections )
             QObject::disconnect( connection );
 
         connections.clear();

src/controls/QskSkinManager.cpp

@@ -58,12 +58,12 @@ namespace
                 without having to load the plugin itself
              */
 
-            constexpr QLatin1String TokenInterfaceId( "IID" );
+            const QLatin1String TokenInterfaceId( "IID" );
-            constexpr QLatin1String TokenData( "MetaData" );
+            const QLatin1String TokenData( "MetaData" );
-            constexpr QLatin1String TokenFactoryId( "FactoryId" );
+            const QLatin1String TokenFactoryId( "FactoryId" );
-            constexpr QLatin1String TokenSkins( "Skins" );
+            const QLatin1String TokenSkins( "Skins" );
 
-            constexpr QLatin1String InterfaceId( QskSkinFactoryIID );
+            const QLatin1String InterfaceId( QskSkinFactoryIID );
 
             const auto pluginData = metaData();
             if ( pluginData.value( TokenInterfaceId ) == InterfaceId )

src/inputpanel/QskInputPanel.cpp

@@ -50,8 +50,6 @@ QString qskNativeLocaleString( const QLocale& locale )
                 default:
                     return QStringLiteral( "English (UK)" );
             }
-
-            break;
         }
 
         case QLocale::Spanish: